pyFF icon indicating copy to clipboard operation
pyFF copied to clipboard

Do not crash when entity-selection-profile attribute has invalid JSON

Open enriquepablo opened this issue 1 year ago • 2 comments

All Submissions:

  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you added an explanation of what problem you are trying to solve with this PR?
  • [x] Have you added information on what your changes do and why you chose this as your solution?
  • [x] Have you written new tests for your changes?
  • [x] Does your submission pass tests?
  • [ ] This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

enriquepablo avatar Nov 27 '24 13:11 enriquepablo

We also need to check that the json have a key called profiles. If not sp['profiles'].update(trustinfo['profiles']) will break ?

btmattsson avatar Nov 28 '24 15:11 btmattsson

That would result in a warning in the logs, notice that that line is still in the try block

enriquepablo avatar Nov 28 '24 15:11 enriquepablo