Fix invalid parsing of the bool arguments
This MR aims to fix the a couple of issues in the argument parsing:
-
InvertedSettingincorrectly defines its own__get__and__set__dunder methods. - Boolean arguments are not properly initialized.
-
daemonizeis missingtypeconvsetting.
I have found all these issues (and a few more) while trying to deploy pyff on our infra at CERN.
All Submissions:
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [x] Have you added an explanation of what problem you are trying to solve with this PR?
- [x] Have you added information on what your changes do and why you chose this as your solution?
- [x] Have you written new tests for your changes?
- [x] Does your submission pass tests?
- [x] This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?
I would be really happy if you could apply the hacktoberfest-accepted label to this MR if you find it valuable and decide to merge it.
This crashes in production because of memory issues. Will try to reproduce.
This crashes in production because of memory issues. Will try to reproduce.
Interesting.. These changes lead to memory issues?
no, sorry, I spoke to Hanna and this was sort of a mental note to me that they(/you) have issued with daemon mode and leaking memory.
Ah, ok. That is correct.