pyFF icon indicating copy to clipboard operation
pyFF copied to clipboard

Fix invalid parsing of the bool arguments

Open mic4ael opened this issue 1 year ago • 5 comments

This MR aims to fix the a couple of issues in the argument parsing:

  1. InvertedSetting incorrectly defines its own __get__ and __set__ dunder methods.
  2. Boolean arguments are not properly initialized.
  3. daemonize is missing typeconv setting.

I have found all these issues (and a few more) while trying to deploy pyff on our infra at CERN.

All Submissions:

  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you added an explanation of what problem you are trying to solve with this PR?
  • [x] Have you added information on what your changes do and why you chose this as your solution?
  • [x] Have you written new tests for your changes?
  • [x] Does your submission pass tests?
  • [x] This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

mic4ael avatar Oct 24 '24 09:10 mic4ael

I would be really happy if you could apply the hacktoberfest-accepted label to this MR if you find it valuable and decide to merge it.

mic4ael avatar Oct 24 '24 09:10 mic4ael

This crashes in production because of memory issues. Will try to reproduce.

mikaelfrykholm avatar Apr 02 '25 09:04 mikaelfrykholm

This crashes in production because of memory issues. Will try to reproduce.

Interesting.. These changes lead to memory issues?

mic4ael avatar Apr 02 '25 11:04 mic4ael

no, sorry, I spoke to Hanna and this was sort of a mental note to me that they(/you) have issued with daemon mode and leaking memory.

mikaelfrykholm avatar Apr 02 '25 12:04 mikaelfrykholm

Ah, ok. That is correct.

mic4ael avatar Apr 02 '25 12:04 mic4ael