pyFF icon indicating copy to clipboard operation
pyFF copied to clipboard

Trust Info metadata in JSON blob in entity attribute

Open enriquepablo opened this issue 1 year ago • 3 comments

All Submissions:

  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you added an explanation of what problem you are trying to solve with this PR?
  • [x] Have you added information on what your changes do and why you chose this as your solution?
  • [x] Have you written new tests for your changes?
  • [x] Does your submission pass tests?
  • [ ] This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

enriquepablo avatar Sep 10 '24 17:09 enriquepablo

Hi @enriquepablo , the REFEDS Working Group hasn't finalised the specification of entity attribute yet, so it might be premature to code http://refeds.org/entity-selection-profile in. When are you looking to land this change?

alexstuart avatar Sep 20 '24 11:09 alexstuart

We were going to put this into staging as soon as it was merged and released. The idea is to 1st check that it does not break the current workflow, and then deploy the mdq service that knows how to use the new data produced by pyff, and then deploy the discovery service that knows how to use the new mdq service (all should be backwards compatible). So to reach production it's still some time.

enriquepablo avatar Sep 20 '24 11:09 enriquepablo

(Sorry I sent the prev message too soon) To be safer, I can put aside the add pipe to extract trustinfo from entity attribute commit aside in another branch until the specification is finalized.

enriquepablo avatar Sep 20 '24 11:09 enriquepablo

are we ready to merge this?

leifj avatar Sep 30 '24 08:09 leifj

Yes. If the working group ends up with a different specification, we will do a later update.

enriquepablo avatar Sep 30 '24 09:09 enriquepablo

I have rebased my branch with latest master, and also changed http://refeds.org/entity-selection-profile into https://refeds.org/entity-selection-profile

enriquepablo avatar Oct 10 '24 14:10 enriquepablo