ocpi-toolkit Prefer trailing comma

We currently disallow trailing commas, even though this might be one of the more useful Kotlin features, and is in line with trends in other modern languages like golang. Having trailing commas helps diffs staying smaller, and easier copy'n pasting of code and moving code lines up and down.

Unnecessary trailing comma before ")" (standard:trailing-comma-on-call-site)

I'd suggest we switch from disallowing trailing commas to requiring them.

Jan 12 '24 05:01 atschabu

I agree with you, I also prefer trailing comma. I am not sure why it's disabled by default, there must be a reason (maybe historic because kotlin did not support it at some point?)

But yes, we have to require trailing comma

Jan 12 '24 10:01 lilgallon

I guess we can close this now. Does the author close it, or the maintainer? Contribution guidelines aren't clear on that

Oct 04 '24 01:10 atschabu

Yes, we can close it, there are no written rule on it. It is usually automatically closed by github

fixed in https://github.com/IZIVIA/ocpi-toolkit/releases/tag/R-0.0.41

Oct 04 '24 13:10 lilgallon