dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

remove duplicate properties keys

Open stevenferey opened this issue 2 years ago • 4 comments

What this PR does / why we need it:

Remove duplicate property keys from property files

Which issue(s) this PR closes:

Closes #9169

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

No

Additional documentation:

stevenferey avatar Jul 19 '23 14:07 stevenferey

@stevenferey thanks for the pull request!

I have no idea why but edu.harvard.iq.dataverse.api.FilesIT.testAccessFacet failed:

Screen Shot 2023-07-19 at 4 45 44 PM

From https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9718/1/testReport/junit/edu.harvard.iq.dataverse.api/FilesIT/testAccessFacet/

pdurbin avatar Jul 19 '23 20:07 pdurbin

/push-image

pdurbin avatar Jul 19 '23 20:07 pdurbin

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:9169-duplicate-property-key
ghcr.io/gdcc/configbaker:9169-duplicate-property-key

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jul 19 '23 20:07 github-actions[bot]

FWIW: I've seen this on another PR - #9599. Not sure what it is yet.

qqmyers avatar Jul 19 '23 21:07 qqmyers

@stevenferey - can you make the changes requested above so this can move forward. (If not, let us know if you're OK with the change and we can get someone else to edit.)

qqmyers avatar Jun 17 '24 15:06 qqmyers