dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

Harvest: map publisher tag to distributorName

Open tcoupin opened this issue 3 years ago • 6 comments

What this PR does / why we need it:

Which issue(s) this PR closes:

  • Closes https://github.com/IQSS/dataverse/issues/8739

tcoupin avatar Oct 03 '22 07:10 tcoupin

If you are still interested in this PR, can you please merge and resolve any merge conflicts with the latest from develop? If so, we can prioritize reviewing and QAing the changes. If we don’t hear from you by May 22, 2024, we’ll go ahead and close this PR (it can always be reopened after that date, if there is still interest).

scolapasta avatar Apr 23 '24 23:04 scolapasta

The branch is now up to date with develop and the sql migration file was renamed to match the latest version - please tell me if there is any convention I'm missing.

plecor avatar May 03 '24 08:05 plecor

@plecor can you please add a release note snippet that describes what this pull request does? Please see https://guides.dataverse.org/en/6.2/developers/version-control.html#writing-release-note-snippets

Also, it would be nice to add something to the guides but I'm not sure where. Maybe we should add a changelog to https://guides.dataverse.org/en/6.2/admin/harvestserver.html ? Would that make sense?

Finally, tests are always nice but not strictly required. There are some in HarvestingServerIT.java.

pdurbin avatar May 03 '24 11:05 pdurbin

Thanks @pdurbin.

I created a release note and added the relevant test to HarvestingClientsIT. I'm really not sure however where this would fit in the docs.

plecor avatar May 14 '24 14:05 plecor

@plecor I went ahead and added a new changelog for harvesting clients: https://dataverse-guide--9013.org.readthedocs.build/en/9013/admin/harvestclients.html#harvesting-client-changelog

In review we'll see what others think.

pdurbin avatar May 14 '24 18:05 pdurbin

Coverage Status

coverage: 22.754%. remained the same when pulling 7e72b256598b0f01dfa9d2bfa0a0c394f8a47494 on tcoupin:8739-publisher-during-harvesting into 4dfb9e76d8ae02a06d4817467d7236c3808bf094 on IQSS:develop.

coveralls avatar May 14 '24 18:05 coveralls

This branch has some conflicts to resolve before I can QA.

ofahimIQSS avatar Jan 06 '25 18:01 ofahimIQSS

@ofahimIQSS I updated the branch to resolve the conflict.

plecor avatar Jan 07 '25 07:01 plecor

what harvesting client should this be tested with?

ofahimIQSS avatar Jan 15 '25 16:01 ofahimIQSS

Tested Harvesting, performed regression testing in internal - no issues found. Conflict needs to be resolved.

ofahimIQSS avatar Jan 22 '25 18:01 ofahimIQSS

@ofahimIQSS I resolved the merge conflicts.

pdurbin avatar Jan 22 '25 18:01 pdurbin

Tested after conflict resolution - no issues found. Merging PR

ofahimIQSS avatar Jan 23 '25 14:01 ofahimIQSS