IQSS
7000 mpconfig pid doi hdl
THIS PR RELIES ON #8823 BEING MERGED FIRST, AS IT CONTAINS THOSE COMMITS, TOO!
(Technically you could also merge this one, but it might help to reduce brain load while reviewing when merging the base PR first)
What this PR does / why we need it: This is a larger cleanup of many PID provider settings.
- It decouples the settings from different provider from each other by adding new names and scopes.
- It will reuse existing configuration values to maintain backward compatibility!
- The docs have been consolidated and changed as necessary to line out more of the differences and which things are important for what
- Sane defaults have been incorporated, pointing to test and non-production resources
Relates to #7000
Which issue(s) this PR closes: None.
Special notes for your reviewer: This should be done but might need discussion if we want changes to the installer. (Password aliases etc)
- [x] Missing Handle refactoring
- [X] Missing a release notes file explaining the changes
- [ ] Maybe change installer to use new configuration names
- [ ] HandleNet properties need aliases for old names!
- [X] ~~Maybe extend like done for Solr (#8825) to enable protocol, provider, authority choose etc via MPCONFIG in backward compatible manner? (Much easier config for containers and those settings are VERY static - these shall never change for an installation or you'll be in trouble. Database Settings were introduced for dynamically changing settings? :thinking: )~~ Too large for this PR.
TO SEE ONLY THE CHANGES IMPORTANT FOR THIS PR >CLICK HERE<
Suggestions on how to test this: Play around with the settings described in the docs section and watch it work. It's not much of a change despite the renaming.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: Not really.
Is there a release notes update needed for this change?: Included.
Additional documentation: Included.
Good catch by @landreev - the HandleNet properties are missing their aliases!
Coverage: 20.184% (+0.002%) from 20.182% when pulling b7d64dfc1ff85598738c72d998fae491d9b62cf4 on poikilotherm:7000-mpconfig-pid-doi-hdl into 3a5883ca29a8eafe18639bc4d69cbf55de3d0c87 on IQSS:develop.
The ITs cannot run because Maven fails to install... Sending this to ready for review and sizing anyway.
I suppose this is a size 10 thing. "3" seems not be enough time to review all the text I wrote. And folks might want to test a few things with the PID providers during QA.
Just merged in latest develop which contains a lot of changes to the PID providers, merge conflicts solved!
With the recent change of behaviour in develop that instances of all PID providers are created, there needs to be more logic in place to create only quiet stub instances if not configured completely. (Example related to #9486: no EZID username + password = don't login.) As the PR is now, it would always stumble over the required configuration values.
I'm pulling this back to draft mode, as it needs some tweaks for being sent into the pipe.
new sprint:
- Oliver just pulled this back for more work.
- Moving back to off the board.
- Sounds like this will likely need to be resized once Olivery figures out what's left.
I'm putting this back on the table. @mreekie automation dropped this into "Ready for review", could you move it to the sprint column? Thx! (I am not allowed to do this for some unclear reason...?)
About sizing: this does not need a resizing, it's still a 10.
The overall important added stuff was that Permalink provider is now configurable via MPCONFIG as well as the others. And the EZID provider is created in any case, but no login is attempted if no username and password is given. This was not possible before because we reused the same property name for all places. As this is changed now, it can properly detect if to attempt login or not. The rest are some cosmetic changes.
I'm putting this back on the table. @mreekie automation dropped this into "Ready for review", could you move it to the sprint column? Thx! (I am not allowed to do this for some unclear reason...?)
About sizing: this does not need a resizing, it's still a 10.
The overall important added stuff was that Permalink provider is now configurable via MPCONFIG as well as the others. And the EZID provider is created in any case, but no login is attempted if no username and password is given. This was not possible before because we reused the same property name for all places. As this is changed now, it can properly detect if to attempt login or not. The rest are some cosmetic changes.
@poikilotherm This is fine. Let's leave it be.
Issues found:
- Existing, known good handle config fails with ui error and stack trace: (fixed) hdl_create_err.txt Seems like it really needs new hdl passphrase property. I am not using one for test/qa.
@kcondon I fixed this with b7d64df, only looking up the passphrase if it is required. Hope that helps :smile:
Woo-hoo!!! And another one in! Thanks for testing in depth @kcondon and the positive review @pdurbin ! 🥳