dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

Use production date in citation for harvested dataset

Open tcoupin opened this issue 3 years ago • 5 comments

What this PR does / why we need it:

Date in citation div is the "citation date" which is most of th time the publication date (the first release date) (https://guides.dataverse.org/en/latest/api/native-api.html?highlight=citationdate#set-citation-date-field-type-for-a-dataset).

But for a harvested dataset, the distribution date is used instead and this date is not always present. With oai_dc format the date tag if used as production date (when harvesting (see code) AND serving (see code)).

This PR try to use production date for harvested dataset in addition to distribution date

Which issue(s) this PR closes:

  • Closes #8103

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

tcoupin avatar May 24 '22 15:05 tcoupin

@tcoupin from a very quick look I think we'll need some documentation. A small change to the guides would be great and lasting (more lasting than a release note). In addition, a release note fragment would be nice so we can highlight the change. Please see https://guides.dataverse.org/en/5.10.1/developers/making-releases.html#write-release-notes

pdurbin avatar May 24 '22 15:05 pdurbin

Hi @pdurbin Release note added. But I don't found any section in the guide about citation building to update. The PR affects only the citation generation.

tcoupin avatar May 30 '22 07:05 tcoupin

@tcoupin thanks, you're probably right about the guides.

I hope you don't mind but I'm using your PR to trigger a build on our Jenkins server. 😄

pdurbin avatar Jun 02 '22 18:06 pdurbin

Hi @tcoupin, for this next sprint we are catching up on Community PRs. Would you mind updating/ refreshing thiis PR from develop? Thanks!

scolapasta avatar Aug 04 '22 19:08 scolapasta

I rebase on develop branch

tcoupin avatar Aug 04 '22 20:08 tcoupin

Coverage Status

Coverage decreased (-0.003%) to 20.032% when pulling 6a2ec030610684ad45584304c4473eed9a187753 on tcoupin:tc-citationdate-harvested-dataset into c7b8b8237d5dd736b6aa504f4ea3e73775cab059 on IQSS:develop.

coveralls avatar Sep 13 '22 05:09 coveralls