dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard
verified publisher icon IQSS

use dataset thumbnail if available

Open qqmyers opened this issue 6 years ago • 4 comments

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

  • connects to #5641 (edited by @djbrooke)

Pull Request Checklist

qqmyers avatar Mar 11 '19 18:03 qqmyers

Coverage Status

Coverage remained the same at 19.488% when pulling 624128dbaf209c953d39dd0bb6ab51323fb0086d on QualitativeDataRepository:IQSS-4894-Open_Graph_metadata into ee874a6224af616fd5db20789f0fcb7521238cbf on IQSS:develop.

coveralls avatar Mar 11 '19 18:03 coveralls

Can one of the admins verify this patch?

dataversebot avatar Aug 15 '19 14:08 dataversebot

FWIW: I just resolve the conflict, but, with the changes to make the supplied images higher resolution, this could/should wait until one can specify a higher resolution dataset thumbnail as in #5679

qqmyers avatar Oct 02 '19 13:10 qqmyers

Over at https://github.com/IQSS/dataverse/issues/10220#issuecomment-1897046254 mentioned that this PR increases the dataset logo size (that's my understanding anyway), so it may be a solution for this issue:

  • #9418

pdurbin avatar Jan 18 '24 00:01 pdurbin

Hi @qqmyers 👋🏼 I was thinking that this being a solution on the JSF it would be better to implement this logic on /api/datasets/:persistentId/thumbnail so this solution could also be available to the SPA?

jp-tosca avatar May 23 '24 14:05 jp-tosca

I found a site that can preview the Open Graph images. For example https://orcascan.com/tools/open-graph-validator?url=https%3A%2F%2Fdataverse.harvard.edu%2Fdataset.xhtml%3FpersistentId%3Ddoi%3A10.7910%2FDVN%2FTJCLKP does show the generic Dataverse logo:

(Note that it does say "invalid: Your page is missing Open Graph tags, learn more.)

Screenshot 2024-05-23 at 10-39-08 Open Graph Validator

pdurbin avatar May 23 '24 14:05 pdurbin

I found a site that can preview the Open Graph images.

At least it gives you a nice detail of what is missing 😄

jp-tosca avatar May 23 '24 14:05 jp-tosca

I opened https://github.com/IQSS/dataverse/issues/10586 to keep track of this for the SPA

jp-tosca avatar May 23 '24 15:05 jp-tosca