ILIAS-eLearning
11/data/mail address
This is an EmailAddress Data Type for more consistent and accurate validation.
Since ILIAS is used internationally, we are allowing many more characters than most Email Validators do. Umlauts ä, ö, ü and accented vowels become more and more common since updated standards technically allow them. Sadly, most existing checkers only let a subset of ASCII characters through. For this strict validation you can use isAscii() to verify that the email address is safe by old standards.
If isAscii() returns false, but the object did not throw an error on construction, it's a valid Unicode email address. However, most email servers (and php itself) cannot handle those optimally by default. One day when this Data Object is actually used for Email Addresses, PHP itself and the web server still need to be configured to handle Unicode strings correctly.
:heavy_check_mark: Rebased :heavy_check_mark: Corrected domain part ASCII check :heavy_check_mark: Corrected PHPStan check error in factory Remaining failing unit tests are deprecation warnings not related to this PR
Hi @mjansenDatabay,
would you be so kind and take care of a final review and approval, to follow the "not the same SP" rule? What's your stance on the formatting issue?
Thanks a lot!
Hi @klees / @catenglaender ,
yes, I will merge this after the formatting issue (and the merge conflict) has (have) been solved.
Best regards Michael
Thank you everyone! :slightly_smiling_face:
formatting fixed merge conflict solved