ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard
verified publisher icon ILIAS-eLearning

9/Learning-Sequence push footer down 41463

Open catenglaender opened this issue 1 year ago • 1 comments

https://mantis.ilias.de/view.php?id=41463

Issue

Footer is not positioned at the bottom of the content area. Header overlaps Slate and content area slightly.

image

Change

Learning Sequence kiosk mode had no content div that actually stretches and pushes the footer down. Used the mainspacekeeper ID for the content area in the html template which comes with the layout styling that was missing in this kiosk mode.

Deleted left overs from a previous implementation of the mode info.

image

Outlook

Footer issue needs to be solved in 9+ as well.

catenglaender avatar Jun 17 '24 13:06 catenglaender

Hi @catenglaender

Thx a lot for the fix along with the detailed description. Highly appreciated. However, the change to a prominent ID in the template is critical for a productive release. We never know what JS in core/and or plugins are relaying on this. Therefore, we would like to take this to the JF.

thx.

Amstutz avatar Jun 25 '24 07:06 Amstutz

Jour Fixe, 08 JUL 2024: We accept the suggested change of the ID for Release_9 and trunk. Please add a short notice to the Release Page of ILIAS 9 -> Changed Behaviour to notify users that have a customised skin.

matthiaskunkel avatar Jul 08 '24 12:07 matthiaskunkel

Hi @catenglaender,

please create a PR that solves this very issue for ILIAS >9!

Kind regards!

klees avatar Jul 12 '24 14:07 klees