ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

[IMPROVEMENT] simplified stakeholder default owner

Open chfsx opened this issue 1 year ago • 1 comments

most of the existing stakeholders implement a mechanism to find out the current user and thus the owner of new resources. the methods for this differ slightly in some cases and, for example, this currently leads to problems in trunk during migrations.

With the PR, the methodology for this is moved to the AbstractResourceStakeholder and can therefore be improved centrally.

feedback welcome! if i do not receive any objections, i would merge the PR next week.

chfsx avatar Jun 05 '24 06:06 chfsx

Thanks for the PR. The code looks cleaner. Personally I never fully understood the owner concept. Is it documented anywhere? I assume that it is completely unrelated to the owner concept in the repository. But e.g. file objects in the repo now have a repo owner and a resource owner, right? This is somehow confusing. What is the concept of being a resource owner? Isn't it just the creator of the resource?

alex40724 avatar Jun 05 '24 06:06 alex40724

I had accidentally committed the commit to trunk, but have just reverted it.

Committed in: https://github.com/ILIAS-eLearning/ILIAS/commit/5d8b490561603711be86eb0d64391f2c8dfef217

Reverted in: https://github.com/ILIAS-eLearning/ILIAS/commit/26b9854eb654602955768243494ddfdc27fbdc88

i'll make a new PR, at least for the components that would have accepted the changes so far. I don't know what to do with the rest.

chfsx avatar Aug 05 '24 11:08 chfsx