ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

UI: DataTable, port from trunk; include URLBuilder, ViewControls, restructured Inputs

Open nhaagen opened this issue 2 years ago • 7 comments

This adds the DataTable and InputViewControls to v8.

nhaagen avatar Aug 23 '23 07:08 nhaagen

@nhaagen Do we understand why the tests don't run? @mjansenDatabay plz halp.

klees avatar Sep 21 '23 08:09 klees

@nhaagen Do we understand why the tests don't run? @mjansenDatabay plz halp.

Here I am.

        _____________________________________________
      //:::::::::::::::::::::::::::::::::::::::::::::\\
    //:::_______:::::::::________::::::::::_____:::::::\\
  //:::_/   _-"":::_--"""        """--_::::\_  ):::::::::\\
 //:::/    /:::::_"                    "-_:::\/:::::|^\:::\\
//:::/   /~::::::I__                      \:::::::::|  \:::\\
\\:::\   (::::::::::""""---___________     "--------"  /::://
 \\:::\  |::::::::::::::::::::::::::::""""==____      /::://
  \\:::"\/::::::::::::::::::::::::::::::::::::::\   /~::://
    \\:::::::::::::::::::::::::::::::::::::::::::)/~::://
      \\::::\""""""------_____::::::::::::::::::::::://
        \\:::"\               """""-----_____:::::://
          \\:::"\    __----__                )::://
            \\:::"\/~::::::::~\_         __/~:://
              \\::::::::::::::::""----""":::://
                \\::::::::::::::::::::::::://
                  \\:::\^""--._.--""^/::://
                    \\::"\         /":://
                      \\::"\     /":://
                        \\::"\_/":://
                          \\::::://
                            \\_//
                              "

What's the problem :-)?

mjansenDatabay avatar Sep 21 '23 09:09 mjansenDatabay

@klees dunno, force-pushed and apparently the tests are back

nhaagen avatar Sep 21 '23 11:09 nhaagen

Thx both =)

klees avatar Sep 21 '23 11:09 klees

You called me, and you didn't need me :(. I am feeling so useless^^.

mjansenDatabay avatar Sep 21 '23 13:09 mjansenDatabay

@mjansenDatabay I'm sorry. I thought that we would need your bright mind to solve this =)

klees avatar Sep 21 '23 14:09 klees

picked https://github.com/ILIAS-eLearning/ILIAS/pull/6702

nhaagen avatar Mar 11 '24 14:03 nhaagen

Hi @Amstutz/@thibsy,

we started to incorporate this into our updated cate and could not find problems with the code until now. There are two PRs missing in here, but imho they contain marginal changes. So, from my perspective this is good to go for 8.

Would you be so kind and have a look into this now?

Kind regards!

klees avatar Mar 21 '24 09:03 klees

Jour Fixe, 15 APR 2024: We still prefer to allow plugin developers to use UIDataTable in ILIAS8-plugins and therefore suggest to implement a solution for ILIAS 8 that allows input interfaces to stay in there previous namespaces. We accept breaking changes in interface to the data table and related components as they could not used in ILIAS 8 until now.

matthiaskunkel avatar Apr 15 '24 08:04 matthiaskunkel

We added legacy interfaces for

  • ILIAS\UI\Component\Input\Field\Input
  • ILIAS\UI\Component\Input\Field\FilterInput
  • ILIAS\UI\Component\Input\ViewControl\ViewControl

and marked them as deprecated for 9. That should strongly hint to necessary adjustments without breaking too much.

nhaagen avatar Apr 18 '24 12:04 nhaagen