ToDo-iOS icon indicating copy to clipboard operation
ToDo-iOS copied to clipboard

Fix verbiage for proper commit messages in contributing.md

Open mikaelacaron opened this issue 5 years ago • 2 comments

Description

The contributing file says to use present tense, but the examples were all in past tense.

Type of Change:

  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on contributing file)

How Has This Been Tested?

No tests required

Checklist:

  • [x] I have made corresponding changes to the documentation

Code/Quality Assurance Only

mikaelacaron avatar Oct 03 '20 20:10 mikaelacaron

I didn't use any kind of "parser" or "spell checker" this was noticed when I was reading the file before I began making my own changes. This isn't to be spiteful or spammy.

mikaelacaron avatar Oct 03 '20 20:10 mikaelacaron

@aaryankotharii Understood. I'm surprised that you're wanting the convention to be past tense. On the git website, in the commit guidelines the convention is to use present tense.

This is to be consistent with the commands like git add and git merge, they are in present tense and aren't "git added" or "git merged."

mikaelacaron avatar Oct 05 '20 03:10 mikaelacaron

Closing this so it doesn't show up on my GitHub anymore

mikaelacaron avatar Jul 31 '24 16:07 mikaelacaron