pyPESTO icon indicating copy to clipboard operation
pyPESTO copied to clipboard

Refactor sample result

Open jvanhoefer opened this issue 4 years ago • 2 comments

The sample result was never used, while the McmcPtResult did not ensure a stable interface to the outside world. Fixed that. Might not be the final solution to the problem, but should definitely be an improvement

jvanhoefer avatar Jan 20 '22 22:01 jvanhoefer

Codecov Report

Merging #804 (de013ac) into develop (4c6e013) will increase coverage by 33.90%. The diff coverage is 92.68%.

@@             Coverage Diff              @@
##           develop     #804       +/-   ##
============================================
+ Coverage    51.93%   85.83%   +33.90%     
============================================
  Files          106      106               
  Lines         7560     7574       +14     
============================================
+ Hits          3926     6501     +2575     
+ Misses        3634     1073     -2561     
Impacted Files Coverage Δ
pypesto/__init__.py 100.00% <ø> (ø)
pypesto/objective/history.py 96.00% <ø> (+50.24%) :arrow_up:
pypesto/store/read_from_hdf5.py 91.26% <ø> (+35.71%) :arrow_up:
pypesto/result/sample.py 84.00% <91.66%> (+56.22%) :arrow_up:
pypesto/result/__init__.py 100.00% <100.00%> (ø)
pypesto/result/result.py 100.00% <100.00%> (ø)
pypesto/store/save_to_hdf5.py 96.82% <100.00%> (+24.60%) :arrow_up:
pypesto/optimize/optimizer.py 50.32% <0.00%> (-39.31%) :arrow_down:
pypesto/optimize/task.py 92.30% <0.00%> (-7.70%) :arrow_down:
pypesto/objective/amici_util.py 82.53% <0.00%> (-1.59%) :arrow_down:
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c6e013...de013ac. Read the comment docs.

codecov-commenter avatar Jan 20 '22 22:01 codecov-commenter

@jvanhoefer what's the status here?

yannikschaelte avatar Aug 01 '22 19:08 yannikschaelte