pyPESTO icon indicating copy to clipboard operation
pyPESTO copied to clipboard

Feature separate likelihood and prior

Open jvanhoefer opened this issue 4 years ago • 1 comments

  • [x] add get_negloglikelihood and get_neglogposterior in all the different objectives.
  • [x] Go through samplers, and adapt them, if null & prior are needed separately
  • [x] remove problem.x_priors
  • [x] Adapt tests...

jvanhoefer avatar Dec 17 '21 17:12 jvanhoefer

Codecov Report

Merging #779 (a000222) into develop (972f934) will decrease coverage by 43.29%. The diff coverage is 31.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #779       +/-   ##
============================================
- Coverage    90.02%   46.73%   -43.30%     
============================================
  Files           98       98               
  Lines         6888     6954       +66     
============================================
- Hits          6201     3250     -2951     
- Misses         687     3704     +3017     
Impacted Files Coverage Δ
pypesto/objective/aesara.py 0.00% <0.00%> (-92.93%) :arrow_down:
pypesto/petab/importer.py 89.56% <ø> (ø)
pypesto/problem.py 69.49% <ø> (-22.13%) :arrow_down:
pypesto/sample/emcee.py 28.30% <0.00%> (-69.82%) :arrow_down:
pypesto/sample/metropolis.py 26.02% <0.00%> (-71.31%) :arrow_down:
pypesto/sample/pymc3.py 33.33% <0.00%> (-60.52%) :arrow_down:
pypesto/objective/util.py 54.16% <15.00%> (-35.49%) :arrow_down:
pypesto/objective/aggregated.py 67.18% <40.00%> (-32.82%) :arrow_down:
pypesto/objective/finite_difference.py 18.29% <42.85%> (-75.85%) :arrow_down:
pypesto/objective/function.py 75.20% <42.85%> (-19.72%) :arrow_down:
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 972f934...a000222. Read the comment docs.

codecov-commenter avatar Dec 17 '21 20:12 codecov-commenter