pyPESTO icon indicating copy to clipboard operation
pyPESTO copied to clipboard

Obtain correct parameter scale from petab import in parameter names

Open elbaraim opened this issue 5 years ago • 2 comments

When petab problem is imported in pypesto would be good to update parameter names according to the scale: lin, log or log10. In case being lin leave as it is. In case any of the others change during import to, e.g., log(parameter_name) or log_{10}(parameter_name)

elbaraim avatar Apr 02 '20 09:04 elbaraim

and/or to adapt the scale of the visualisation. e.g. visualise a log-transformed values on a log scale

JanHasenauer avatar Apr 02 '20 09:04 JanHasenauer

in that case, it might be best to have an additional field in the pypesto.Problem class "x_scales", which takes the scale for each parameter. One just has to be aware that unlike in petab, in pypesto we assume all values to be scaled already, e.g. the nominal values and bounds. For optimization this is best this way, however when defining priors one will have to be a bit careful.

yannikschaelte avatar Apr 02 '20 09:04 yannikschaelte