equal-access icon indicating copy to clipboard operation
equal-access copied to clipboard

Update RPT_Blockquote_HasCite rule messages

Open shunguoy opened this issue 3 years ago • 1 comments

The "RPT_Blockquote_HasCite" rule checks if a "blockquote" element has a "cite" attribute or one or more "cite" element(s) as its child(ren). However, the rule messages don't reflect what the rule actually checks:

  `
        "Pass_0": "Rule Passed",
        "Potential_1": "Verify that <blockquote> is used only for quotations, not indentation",
        "group": "Use <blockquote> only for quotations, not indentation"
  ` 

shunguoy avatar Jun 17 '22 15:06 shunguoy

Triage: Help/Message do not correctly state what is happening. This needs to be reworded.

The new message will be similar to: "Verify if blockquote has cite attribute or cite child elements"

The test cases/baselines will need to be updated

aliunwala avatar Jul 18 '22 21:07 aliunwala

Current help page for blockquote_cite_exists image

philljenkins avatar Oct 18 '23 16:10 philljenkins

Working on two other higher-priority issues before this one

philljenkins avatar Nov 10 '23 15:11 philljenkins

Rule was renamed to blockquote_cite_exists.ts "Potential_1": "Verify that <blockquote> should not be used only for quotations, not indentation", "group": "Use <blockquote> only for quotations, not indentation"

See box note for discussion and proposed changes blockquote_cite_exists rule

philljenkins avatar Dec 05 '23 23:12 philljenkins

reviewed changes in the team Showcase image

philljenkins avatar Dec 07 '23 15:12 philljenkins

... or child element

was removed from the message and help content since no HTML examples use the <cite> element as children of <blockquote>. All the examples shown are used separately from <blockquote>, so only the attribute is mentioned in the message and help.

philljenkins avatar Dec 07 '23 21:12 philljenkins