plex icon indicating copy to clipboard operation
plex copied to clipboard
verified publisher icon IBM

Families.js generates scss for italic fonts that don’t exist for all languages

Open alisonjoseph opened this issue 7 years ago • 6 comments

families.js currently assumes all fonts have all weights, which is not the case. Needs to be updated to only generate scss/css for the font weights that exist.

Related to: https://github.com/IBM/plex/issues/183

alisonjoseph avatar Jul 31 '18 16:07 alisonjoseph

All fonts have 8 weights.

mjabbink avatar Nov 01 '18 01:11 mjabbink

Hey @mjabbink sorry I didn't name this issue correctly. Not all fonts have italic versions and the script generates scss for that.

alisonjoseph avatar Nov 01 '18 01:11 alisonjoseph

gotcha

mjabbink avatar Nov 01 '18 01:11 mjabbink

That is true. Hebrew and Thai do not have Italics. The upcoming Devanagari and Arabic also do not have italics. Should I close this issue or leave open?

mjabbink avatar Nov 01 '18 01:11 mjabbink

We should leave open for now, @joshblack is going to help to fix the script to generate the correct files. It may also make sense to keep this repo to only hold the fonts, and move the sass file generation to the elements repo.

alisonjoseph avatar Nov 01 '18 13:11 alisonjoseph

Kind of resolved on the most recent version - it will still generate the italic folders for non-english languages, but it will not import them. So it's usable for now

sockol avatar Dec 18 '18 21:12 sockol