operator-sample-go icon indicating copy to clipboard operation
operator-sample-go copied to clipboard

Test Case 10 : DatabaseBackup yaml has incorrect cron frequency

Open deleeuwblue opened this issue 3 years ago • 4 comments

Issue: The sample DatabaseBackup CR specifies a cron job schedule of "*/3 * * * *" which is every 3 minutes. This is too frequent and ends up filling the COS instance with many buckets which makes it hard to navigate or delete. The frequency should be once per day.

The golden version of this file should be updated: https://github.com/IBM/operator-sample-go/blob/main/operator-database/config/samples/database.sample_v1alpha1_databasebackup.yaml

This requires changing the associated template.

Link to the documentation:

deleeuwblue avatar Jun 07 '22 13:06 deleeuwblue

What is the new value for the schedule "*/3 * * * *" for the database instance back yaml https://github.com/IBM/operator-sample-go/blob/main/scripts/database-operator-templates/database.sample_v1alpha1_databasebackup-TEMPLATE.yaml ?@deleeuwblue

thomassuedbroecker avatar Jun 08 '22 08:06 thomassuedbroecker

schedule: "0 0 * * *" will preform the backup every day at midnight. That should be fine for demo purposes. @thomassuedbroecker

deleeuwblue avatar Jun 08 '22 10:06 deleeuwblue

@deleeuwblue I updated the template in that commit: https://github.com/IBM/operator-sample-go/commit/6e22b3dd094bee4277983ca4356d5bc82daaabf8 , if it works we can close that issue.

thomassuedbroecker avatar Jun 08 '22 11:06 thomassuedbroecker

@Vishal-Ramani can you please verify the fix?

thomassuedbroecker avatar Jul 07 '22 08:07 thomassuedbroecker