linkifyjs icon indicating copy to clipboard operation
linkifyjs copied to clipboard

Japanese Punctuation Breaking Link Detection

Open rudolphventer opened this issue 3 years ago • 4 comments

Hi, in Japanese it is common to quote links in brackets like so 続行する前に、このリンク「https://testdomain.com」を参照してください。

This causes an issue with Linkify where the rest of the paragraph after the link is also linkified as the char does not have any whitespace after it as the character itself seems to contain a space.

This usage is equivalent to the use of round brackets which Linkify does account for, i.e there will always be an opening and closing bracket. Would it be possible to add these brackets to the existing bracket logic?

There are three types of brackets used this way 「 」,『』and【】

rudolphventer avatar Nov 02 '22 14:11 rudolphventer

Hi @rudolphventer, thanks for reporting, will consider this for a future release.

nfrasser avatar Nov 10 '22 14:11 nfrasser

What's more,(https://testdomain.com)test param or a paragraph also will be linkified, can we add some exclude characters to ignore ?

Sapphire2k avatar Jul 11 '23 10:07 Sapphire2k

Hey guys, I mentioned this issue in one of our PRs, because it seems that this happens also with letters that come before the https protocol mark such as examplehttps://, this becames clearer when dealing with japanese sentences as showed in our issue https://github.com/bigbluebutton/bigbluebutton/issues/18313.

Considering that, we had a quick fix, but we would like to know if you guys are planning on dealing with the scenario I brought, or just punctuations before the link.

Thank you in advance.

GuiLeme avatar Jul 19 '23 18:07 GuiLeme