label-studio icon indicating copy to clipboard operation
label-studio copied to clipboard

fix: LEAP-921: Fix the way of updating users in store

Open Gondragos opened this issue 1 year ago • 5 comments

This PR deprecates using of mergeUsers and adding enrichUsers instead.

PR fulfills these requirements

  • [x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • [ ] Tests for the changes have been added/updated (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • [ ] Product design
  • [ ] Backend (Database)
  • [ ] Backend (API)
  • [x] Frontend

Describe the reason for change

This was done, 'cause mergeUsers didn't update existing users and could lose some changes that should be applied. This is actual when we already have list of users that includes email and names and then we try to add more information or some new version of it, like an added avatar field.

Does this PR introduce a breaking change?

  • [ ] Yes, and covered entirely by feature flag(s)
  • [ ] Yes, and covered partially by feature flag(s)
  • [x] No
  • [ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • [ ] e2e
  • [ ] integration
  • [ ] unit

Which logical domain(s) does this change affect?

Comments, Users

Gondragos avatar Apr 24 '24 13:04 Gondragos

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
Latest commit 9cde780ecdaae8278c6a63fb3494be5cdfdb6a7c
Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66350137bcf11f0008f3ba57

netlify[bot] avatar Apr 24 '24 13:04 netlify[bot]

Deploy Preview for heartex-docs canceled.

Name Link
Latest commit 9cde780ecdaae8278c6a63fb3494be5cdfdb6a7c
Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66350137ab1b280008b45063

netlify[bot] avatar Apr 24 '24 13:04 netlify[bot]

/git merge develop

Workflow run Successfully merged: 1 file changed, 1 insertion(+), 1 deletion(-)

Gondragos avatar Apr 24 '24 15:04 Gondragos

/git merge develop

Workflow run Successfully merged: 1132 files changed, 60025 insertions(+), 61739 deletions(-)

Gondragos avatar Apr 29 '24 15:04 Gondragos

/git merge develop

Workflow run Successfully merged: 31 files changed, 2806 insertions(+), 266 deletions(-)

Gondragos avatar May 02 '24 22:05 Gondragos