Rename config for docker

[ionphractal]

After changing the domains to xip.io, a local Docker development environment was unable to load images (failing with 401 unauthorized). That is because the JWT token audience uri was still set to localhost and hence the token was not recognized as valid.

The configuration package loads the config from NODE_ENV. And as there was no development config and Docker uses "development" I though I'd rename the config and extend it with the required parameters.

Does this break anything on your side? @appinteractive @roschaefer

[appinteractive]

This would break the local environment without docker. You might want to use development-docker.json as a filename instead.

[ionphractal]

Hm so we might want to treat NODE_ENV=development-docker as development in code, right?

[roschaefer]

@ionphractal great debugging! Could you use config/default-docker.json instead, please? We set NODE_APP_INSTANCE=docker in the Dockerfile. See the node-config wiki to learn how config files are loaded.

Apart from that :+1:

[roschaefer]

@appinteractive I restarted the build once, can you tell me what's wrong with codacy right now?

[appinteractive]

@roschaefer codacy?

[roschaefer]

It's failing the build.