BuckyServer icon indicating copy to clipboard operation
BuckyServer copied to clipboard

Security changes whitelisting

Open msgauri opened this issue 10 years ago • 8 comments

msgauri avatar Jan 20 '16 15:01 msgauri

Work in progress

msgauri avatar Jan 20 '16 18:01 msgauri

(this addresses #20)

msgauri avatar Jan 20 '16 20:01 msgauri

This one is ready to go in, waiting on review

msgauri avatar Jan 20 '16 20:01 msgauri

Could we check for the presence of whitelistedKeys and use that as the trigger to filter keys instead of having to use a separate boolean?

ckdake avatar Jan 20 '16 20:01 ckdake

So you need atleast one of those keys commented out for the server to start up, else it gives parse errors.

msgauri avatar Jan 20 '16 20:01 msgauri

@zackbloom could you review this and check if its ok to merge this?

msgauri avatar Jan 29 '16 18:01 msgauri

@zackbloom I have uncommented the default keys sent by bucky in the yaml. It should work in its current form. Please check and merge if everything looks right.

msgauri avatar Feb 22 '16 16:02 msgauri

@zackbloom wanted to check with you if you need anything from us after the last comment? Or is this ready to merge?

msgauri avatar Apr 19 '16 14:04 msgauri