DDD icon indicating copy to clipboard operation
DDD copied to clipboard

fixes c-common and d-messenger

Open axbuglak opened this issue 2 years ago • 2 comments

Changes in c-common

  • Fixed db requests in api(must be asynchronous)
  • Fixed delete request in to the db(quotes changed from '' to ``)
  • Fixed http requests (props must be destructured so that they will not be in an array in api's functions)

Changes in d-messenger

  • Fixed http requests (props must be destructured so that they will not be in an array in api's functions)
  • Fixed sql questions in the crud in d-messenger (if table names are written from upper letter, postgresql will understand this only when table names are in quotes)

axbuglak avatar Sep 02 '23 22:09 axbuglak

As Far as I know there's the linter rule to force parenthesis around arrow function params. So some of the changes like following should be reverted

https://github.com/HowProgrammingWorks/DDD/pull/30/commits/904ead585a034c47f6c1bbb3c30b1d9f6df0cc50#diff-d69b4849eedd14f001029f96465f3d351b5a43cbc9ffce2c15dd96608f5fef39R5

Here is mentioned linter rule: https://github.com/HowProgrammingWorks/DDD/blob/master/.eslintrc.json#L214-L216

JaoodxD avatar Dec 06 '23 12:12 JaoodxD

@JaoodxD Yes, you are right. For unknown to me reasons the code was formatted using wrong eslint config(with arrow-parens: as-needed). So its already fixed. Thank you for the comment/review.

axbuglak avatar Dec 06 '23 14:12 axbuglak