brew icon indicating copy to clipboard operation
brew copied to clipboard

cask/audit: update signing checks for app, binary, and pkg

Open krehel opened this issue 1 year ago • 4 comments

  • [ ] Have you followed the guidelines in our Contributing document?
  • [ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [ ] Have you successfully run brew style with your changes locally?
  • [ ] Have you successfully run brew typecheck with your changes locally?
  • [ ] Have you successfully run brew tests with your changes locally?

POC changes to address some issues in auditing Casks, where we are failing some valid Casks.

This doc used as the source material for updating the checks. Based on it, the checks should be different where it is an app, a pkg, or a binary.

This is still not complete, as this will still fail some valid Casks (such as GitHub Desktop), and we need to implement (IMHO) some checking directly DMG's to check signature. But hopeful this kickstarts a conversation.

krehel avatar Apr 04 '24 19:04 krehel

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 27 '24 00:04 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar May 21 '24 00:05 github-actions[bot]

@krehel What's the latest here?

MikeMcQuaid avatar May 21 '24 07:05 MikeMcQuaid

@MikeMcQuaid sorry about that. Will pick this up and see if I can get it over the line. Need to solve some corner cases involving binaries.

krehel avatar May 22 '24 02:05 krehel

Thanks @MikeMcQuaid - apologies it took a bit to pick back up, will do better going forward ❤️

krehel avatar May 22 '24 16:05 krehel

@krehel Zero apologies needed, thanks for the PR!

MikeMcQuaid avatar May 22 '24 18:05 MikeMcQuaid