linux/diagnostic: check `LD_LIBRARY_PATH` when `glibc` is installed.
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? Here's an example.
- [x] Have you successfully run
brew stylewith your changes locally? - [x] Have you successfully run
brew typecheckwith your changes locally? - [ ] Have you successfully run
brew testswith your changes locally?
Adding $HOMEBREW_PREFIX/lib to LD_LIBRARY_PATH breaks many things
when glibc is installed, so let's make sure brew doctor complains
about it.
Closes Homebrew/homebrew-core#109893.
Review period will end on 2022-09-09 at 06:40:48 UTC.
I'm not sure how to test this, since, when I do:
linuxbrew@15eb76ba36ac:~/.linuxbrew/Homebrew$ LD_LIBRARY_PATH=$(brew --prefix)/lib brew doctor
/bin/bash: relocation error: /home/linuxbrew/.linuxbrew/lib/libc.so.6: symbol _dl_audit_preinit, version GLIBC_PRIVATE not defined in file ld-linux-x86-64.so.2 with link time reference
Review period ended.
The original issue Homebrew/homebrew-core#109893 is resolved by #13873. Now we should check that etc/ld.so.conf and etc/ld.so.conf.d/*.conf do not point outside HOMEBREW_PREFIX.
- https://github.com/Homebrew/brew/pull/13873
- https://github.com/Homebrew/homebrew-core/pull/109998
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.