ADD crypto-fields

[kamil1marczak]

Hi I have added package of encrypted fields,

[codecov-commenter]

Codecov Report

Merging #160 (714ecae) into master (252e681) will increase coverage by 0.01%. The diff coverage is 93.16%.

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   93.02%   93.04%   +0.01%     
==========================================
  Files           9       11       +2     
  Lines         789      949     +160     
==========================================
+ Hits          734      883     +149     
- Misses         55       66      +11     

Impacted Files	Coverage Δ
drf_extra_fields/crypto_fields.py	88.40% <88.40%> (ø)
tests/test_crypto_fields.py	96.70% <96.70%> (ø)
drf_extra_fields/runtests/settings.py	86.66% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 252e681...714ecae. Read the comment docs.

[yigitguler]

Hi @kamil1marczak, thank you for this detailed PR.

We will review it and get back to you.

[alicertel]

Thank you for your PR, we much appreciate it! However, I guess there is a misunderstanding here (and yes, I have realized it now, after reviewing your PR... 😓). This package includes extra fields for DRF (Django Rest Framework) Serializer fields, not for Django model fields (at least until now). I don't know what can/should we do about it. Any thoughts @alicertel?

Good catch @omerfarukabaci . I didn't realize that. You are right our package includes only DRF fields. I believe this pr is more suitable to https://django-extensions.readthedocs.io/en/latest/field_extensions.html

[kamil1marczak]

I am really sorry for the obvious mistake, I will rewrite it to operate as serialization and include all of your comments from the review. I have few ideas in that matter Can I write you directly in case of seeking consultation on how to get the most utility out of it?

Kamil

wt., 11 maj 2021 o 18:15 alicertel @.***> napisał(a):

Thank you for your PR, we much appreciate it! However, I guess there is a misunderstanding here (and yes, I have realized it now, after reviewing your PR... 😓). This package includes extra fields for DRF (Django Rest Framework) Serializer fields, not for Django model fields (at least until now). I don't know what can/should we do about it. Any thoughts @alicertel https://github.com/alicertel?

Good catch @omerfarukabaci https://github.com/omerfarukabaci . I didn't realize that. You are right our package includes only DRF fields. I believe this pr is more suitable to https://django-extensions.readthedocs.io/en/latest/field_extensions.html

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Hipo/drf-extra-fields/pull/160#issuecomment-838768512, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBYAGQUJPPUJFYADSVB7LDTNFJ2TANCNFSM43QRZHIA .

[kamil1marczak]

@omerfarukabaci @alicertel everything has been rewritten to drf fields. I will be grateful for another review

[alicertel]

Thanks @kamil1marczak I will review this within this week.

[kamil1marczak]

Thanks @kamil1marczak I will review this within this week.

@alicertel hey any progress?