drf-extra-fields icon indicating copy to clipboard operation
drf-extra-fields copied to clipboard

polygon field added

Open soheildsh opened this issue 4 years ago • 4 comments

I tried to add polygon field from geodjango. thanks for you consideration.

soheildsh avatar Feb 22 '21 07:02 soheildsh

Codecov Report

Merging #155 (60929b6) into master (480b6b9) will decrease coverage by 1.16%. The diff coverage is 80.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   93.67%   92.51%   -1.17%     
==========================================
  Files           9        9              
  Lines         759      855      +96     
==========================================
+ Hits          711      791      +80     
- Misses         48       64      +16     
Impacted Files Coverage Δ
drf_extra_fields/geo_fields.py 86.95% <78.57%> (-5.73%) :arrow_down:
tests/test_fields.py 95.02% <81.25%> (-1.81%) :arrow_down:
drf_extra_fields/fields.py 90.05% <0.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 480b6b9...60929b6. Read the comment docs.

codecov-io avatar Feb 22 '21 08:02 codecov-io

Hi @yekmolsoheil Thank you for the great addition. I've made a suggestion to make it more compatible with django's Polygon field.

alicertel avatar Mar 03 '21 12:03 alicertel

Hi. I'm on it. Soon I will also add the things that you said. thanks for your consideration and excellent review and additions.

soheildsh avatar Mar 04 '21 04:03 soheildsh

Hey. Polygons with interior rings are added to be supported. also the tests have been passed. Can you now try to review this one more time. If the code is ok we may proceed to add this feature. Thanks

soheildsh avatar Aug 15 '21 16:08 soheildsh