Himess comments

Results 33 comments of


                                            Himess

fix: replace deprecated #[clap(...)] with #[command(...)] and #[arg

@sveitser Ready for review sir.

Fix govuln CI in v0.38.x-celestia

I think we can close it via #2024

nodebuilder/node: `Init` should also generate and save node ID and JWT secret

@renaynay @Wondertan Hi! I opened a PR (#4232) that adds Node ID and JWT secret generation as suggested here. Let me know if there’s anything missing or that needs adjustment....

batcher: remove isPectra and assume Pectra is always active

@geoknee Checked `op-e2e/system/da` - the `L1PragueTimeOffset` in `eip4844_test.go` is just test config to activate Prague at genesis, not a runtime check like isPectra was. No similar simplification needed there. There's...

Incorrect structured comments about return value of readMem and readMemUnchecked

Is it live ? If yes i want to take this

op-program: Bedrock contracts test setup fails due to incorrect Solady library mapping

Can i work on this ?

Remove `isPectra` from the batcher

I've looked into this and it seems like changes are needed in around 5 Go files. Can I take this?

test stdlib against malicious `AdviceProvider`

Can i take this ? Happy to work.

Consider removing Blake3-192 variant

@bobbinth So i think we need to close it too. https://github.com/0xMiden/miden-vm/pull/2425#issuecomment-3618803761

Remove `NodeExecutionState` from `CoreTraceFragmentContext`

Can i take ?