Nathan Ridge

Results 1499 comments of Nathan Ridge

(Transferred to server repository, the issue affects all clients)

> Did this also depend on #412? Yes, #412 is a dependency, but additional work is required for this issue

Labelling something as an enhancement is not a value judgment that it's less important than a bug. I doubt it materially impacts anyone's decision about whether or when to work...

> Can anyone explain the main difficulties of this problem? The main difficulty with a **general** solution to this is that clangd does not parse the bodies of function templates...

> I have little-to-no experience with the llvm codebase (beyond playing around with a simple clang-tool, years ago), but I could probably give it a swing. Seems like an interesting...

(Generalized issue title slightly, since there is some discussion of other constructor-like functions in the comments above as well, even if an initial fix might only apply to `make_unique`)

> We can also consider some approaches for handling things other than `std::make_unique`: > > [...] > > * We can consider approaches for recording references that don't require the...

> both have good compile_commands.json file, question is that, why the inconsistency? I would expect either all of them work, or all of them fail. It's hard to say without...

I believe that's expected. If I were to manually type `pp->layer1->layer2->layer3->str3` there, I would get an error, `Incomplete definition of type 'struct layer3'`, so it makes sense for clangd not...