react-scroll-to-top icon indicating copy to clipboard operation
react-scroll-to-top copied to clipboard

mount/unmount Animation (issue #48)

Open prajwal-np opened this issue 2 years ago • 2 comments

#48

  • Mount and Unmount animation integration.
  • Validation error fix

prajwal-np avatar Mar 01 '23 11:03 prajwal-np

@HermanNygaard I have created PR for mount and unmount animation please review it and let me know if this is acceptable or not.

prajwal-np avatar Mar 03 '23 09:03 prajwal-np

@prajwal-np thanks a lot! I suppose an alternative solution would be to not conditionally render the button, and instead use CSS for visibility. That way we don't need the delayMount hook. What do you think?

I'm also not sure what animation we should default to (if any?). There should be a way to override the animation.

HermanNygaard avatar Mar 03 '23 17:03 HermanNygaard