Alex Xu

Results 91 comments of Alex Xu

as I said in the other issue, this is bad because you are doing unnecessary heap allocations in a hot path. apparently that code has always checked len > 1024,...

I mean just use a 1024-byte buffer because of the length check right before.

they've been there for over six years, so...

also note that `makedist.sh` doesn't exist anymore, and that DT supports both Qt 4 and 5.

also note that reading is hard. :P

the standard for packages names is pkgname-ver.ext.

https://github.com/splintermind/Dwarf-Therapist/blob/DF2016/src/dfinstancewindows.cpp#L66

hm. I thought the header sizes were different, but that wouldn't make any sense. meh

this patch is not correct. inotify_init is not the same as inotify_init1. this leaves whatever junk was previously in x0 as flags, which should always be 1 from PyArg_ParseTuple. kernel...

> * It's faster. For me gst-build configuration goes from 20s to 17s, that's because we don't have to fork+exec and re-parse all pc files for each pkg-config invocation. I...