Reader icon indicating copy to clipboard operation
Reader copied to clipboard

doesn't seem to work

Open benemanuel opened this issue 3 years ago • 3 comments

All my attempts came out Could not find reference ""

benemanuel avatar Jul 14 '22 10:07 benemanuel

@benemanuel Maybe there is an empty line at the end of the input? The example the application gives when you open the web page works for me.

camilstaps avatar Jul 14 '22 12:07 camilstaps

eg: https://reader.hebrewtools.org/reader?passages=Exodus+20%3A2%E2%80%9317%0D%0ADeuteronomy+5%3A6%E2%80%9318&text_size=0&include_voca=on&combine_voca=on&fmt=pdf returns 502 Bad Gateway nginx/1.18.0 (Ubuntu) I tried other examples but only with the first two Psalms 1 Exodus 3:15 worked.

benemanuel avatar Jul 14 '22 13:07 benemanuel

Okay, that's a different error from Could not find reference "". The problem seems to be that the references include en-dashes (), whereas the application expects regular dashes (-). So the working URL is: https://reader.hebrewtools.org/reader?passages=Exodus+20%3A2-17%0D%0ADeuteronomy+5%3A6-18&text_size=0&include_voca=on&combine_voca=on&fmt=pdf

I know that en-dashes are meant for number ranges and can review a PR that fixes this, but currently don't have time to do that myself.

camilstaps avatar Jul 14 '22 17:07 camilstaps