hxnodejs icon indicating copy to clipboard operation
hxnodejs copied to clipboard

Make basic Socket writing, so Http could work

Open neimanpinchas opened this issue 3 years ago • 7 comments

HTTPS still not working as we must implement/override Http customRequest

neimanpinchas avatar Oct 30 '22 17:10 neimanpinchas

Could this get merged?

Jarrio avatar Feb 25 '23 16:02 Jarrio

You mean to ask my permission? Of course, I made a pull request a while ago.

I have already a few additional commits (Process, SQLite) once things get moving.

With web-workers, we could already remove the dependency on deasync too.

This is what I wonder in my head

If something is wrong with the commit what? If the maintainers have no time for it, maybe enable us to maintain? If the maintainers have no purpose for it, I do have! Did I miss somethings, what?

neimanpinchas avatar Feb 27 '23 16:02 neimanpinchas

Ahh, no, i was bumping for the maintainers. This has kind of been sitting idle for a lil while and it works fine. I was about to do the same work myself before checking to see if someone else had done the work

Jarrio avatar Feb 27 '23 16:02 Jarrio

Hi @neimanpinchas, thanks for your PR! Do you have an example usage of this so I could add corresponding tests, and check that everything is working properly? (tests happen in a different repo, it's understandable that they wouldn't be handled by contributors here)

kLabz avatar Mar 27 '23 07:03 kLabz

@kLabz It enables http support on the nodejs target

var http = new Http('https://google.com');
http.onData = (resp) -> {
   trace(resp);
}
http.request();

Currently does not work, with this pr the above code would now work

Jarrio avatar Mar 27 '23 10:03 Jarrio

I do not see a test folder, can you give a hint on where the test are added?

Thanks

neimanpinchas avatar Mar 27 '23 13:03 neimanpinchas

HTTPS still not working but that would work

var http = new Http('http://example.com');
http.onData = (resp) -> {
   trace(resp);
}
http.request();

neimanpinchas avatar May 09 '24 21:05 neimanpinchas