Takashi Hashida
Takashi Hashida
@kou Would you re-review this when you have time? @yoshimotoyuk Would you review English of this change when you have time?
Thanks, I have reflected the feedback.
Thank you. I have reflected the feedback.
> I have tried to use check object_list but the object of `ShortText` is opened even after change... I found that this is because the `load` command does not close...
Please refer the commit https://github.com/groonga/groonga/pull/1353/commits/91efcde8f6becae81086e1c663b283ad238a325f if you want to check the diff of the test before/after change.
The changed line is passed when `obj->header.type` is `GRN_DB` or `GRN_TYPE`. https://github.com/groonga/groonga/blob/91efcde8f6becae81086e1c663b283ad238a325f/lib/db.c#L7079 > ``` > table_create URLs TABLE_HASH_KEY ShortText > table_create Sites TABLE_NO_KEY --value_type URLs > ``` At the query...
> We can remove `case GRN_DB :` because `grn_db` is never found by `grn_ctx_at()`. > > We can remove `DB_OBJ((*rp)->obj)->range` check because all built-in types have `range` and we don't...
> We can remove `DB_OBJ((*rp)->obj)->range` check because all built-in types have `range` and we don't support user defined types for now. The test below failed after removing `DB_OBJ((*rp)->obj)->range` check, so...
I feel like testing this at CI/CD is some how difficult for now because it seems that there are no good way to checking a `lock` count in CI/CD. Do...