HarvsG
HarvsG
Hey, what is the status of this PR? Looks as if it needs a test?
Ready for review. @dgomes was the reviewer for the previous PR. (Sorry if the @ tag was the wrong thing to do)
> Can you quickly walk me through the need to check `test_multiple_numeric_observations` ? As in the need for the test to exist? Essentially because that is the new feature added...
Test is not failing on my system.
> As in explain what is being tested for documentation purposes :) I have added a better description. ```python async def test_multiple_numeric_observations( hass: HomeAssistant, issue_registry: ir.IssueRegistry ) -> None: """Test...
> ruff is failing, please address the error message @dgomes Should be fixed in 9a85bf8 which I snuck in seconds before your comment. (Github Workflow must be running a newer/different...
> Looks good, some minor comments on code style Changes implemented
@emontnemery, really sorry for the @, just wondering if you could spare a moment to re-review as I have another PR #122552 with merge conflicts that is about to come...
In the meantime, this fork is fairly well maintained: https://github.com/jonandel/ha-hildebrandglow-dcc
Interesting, thanks. That makes it rather confusing why my bindings seem to occasionally stop working, because when they do they are still in the controller's binding table