Rotten-Scripts icon indicating copy to clipboard operation
Rotten-Scripts copied to clipboard

Pdf reader

Open dvs-chandana opened this issue 4 years ago • 12 comments

Description

Fixes #1133

I have added a PDF_Reader folder under the folder Python It has the following files:

  • pdf_reader.py which contains the actual code,
  • README.MD which contains the description of the project,
  • requirements.txt which contains all the dependencies to be installed,
  • sample_pdf.pdf which is a sample pdf file used in demo video,
  • output_video_pdfreader.mp4 which is a demo video of the output (As the voice has to be recorded, I uploaded a video instead of a screenshot).

Type of change

  • [x] New feature (non-breaking change which adds functionality)

Checklist:

  • [x] My code follows the style guidelines(Clean Code) of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have created a helpful and easy to understand README.md
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

dvs-chandana avatar Jun 22 '21 12:06 dvs-chandana

@chandu6111 Thank you for Opening pull request. We will get back to you as soon as possible. Your patience is greatly appreciated! Thanks! 🥳. PS: Please double check that you linked the corresponding issue.

github-actions[bot] avatar Jun 22 '21 12:06 github-actions[bot]

@HarshCasper please review my PR

dvs-chandana avatar Jun 22 '21 12:06 dvs-chandana

@RohiniRG please do review the changes committed now. Let me know if there is anything else I forgot

dvs-chandana avatar Jun 23 '21 14:06 dvs-chandana

Hey @chandu6111 great work . Only few minor changes from my side remove both .mp4 and .pdf files. and use main function to drive the code.

iamakkkhil avatar Jun 28 '21 09:06 iamakkkhil

@iamakkkhil done with those changes. Please review once

dvs-chandana avatar Jun 28 '21 11:06 dvs-chandana

@chandu6111 any updates on the same ??

iamakkkhil avatar Jul 05 '21 03:07 iamakkkhil

@chandu6111 any updates on the same ??

I am working on it @iamakkkhil please give me 2 days, I will commit changes

dvs-chandana avatar Jul 05 '21 03:07 dvs-chandana

@chandu6111 any updates on this?

RohiniRG avatar Jul 11 '21 05:07 RohiniRG

@iamakkkhil and @RohiniRG are the changes okay now?

dvs-chandana avatar Jul 12 '21 16:07 dvs-chandana

@iamakkkhil and @RohiniRG Could you please tell me if the changes are okay?

dvs-chandana avatar Jul 18 '21 13:07 dvs-chandana

LGTM... @HarshCasper please have a look

RohiniRG avatar Jul 19 '21 05:07 RohiniRG

Hey @RohiniRG or @HarshCasper I made changes long back... please do review once... because my issue has been unassigned and made up-for-grab

dvs-chandana avatar Aug 01 '21 01:08 dvs-chandana