Slide-iOS icon indicating copy to clipboard operation
Slide-iOS copied to clipboard
verified publisher icon Haptic-Apps

Move to a different YouTube library

Open colejd opened this issue 7 years ago • 4 comments

The YouTube library provided by Google is currently going over two years since its last change, and it has some major problems with iOS 12 on Swift 4.2. Interesting discussion here. We should consider moving to one of the alternatives from that link.

colejd avatar Nov 13 '18 14:11 colejd

With similar implementation I have ported the Google library into Swift here YoutubePlayerView

mukeshydv avatar Dec 18 '18 09:12 mukeshydv

I did a lightweight replacement in this PR: https://github.com/ccrama/Slide-iOS/pull/920

It may not be our end goal, but it at least provides a WKWebView and API parity so it can be lived with for longer than the Google official library.

CometDog avatar Sep 29 '19 21:09 CometDog

I’m not sure if my change truly averted the suggested issues that @colejd is noting here. The library I replaced it with is just a fork today swapped to WKWebView as far as I’m concerned. I don’t know if it changed much else.

CometDog avatar Oct 17 '19 22:10 CometDog

Any thoughts on this still @colejd @PiwwowPants ?

ccrama avatar Jul 15 '20 22:07 ccrama