NModbus4.NetCore icon indicating copy to clipboard operation
NModbus4.NetCore copied to clipboard

fix ReadWriteMultipleRegister support

Open pieterg opened this issue 2 years ago • 0 comments

ReadWriteMultipleRegister support is not working, because the generated frame is incomplete. The frame is created by ModbusMessageImpl.MessageFrame, which calls ModbusMessageImpl.ProtocolDataUnit internally, instead of the overridden ReadWriteMultipleRegisterRequest.ProtocolDataUnit. By overriding ModbusMessageImpl.MessageFrame in ReadWriteMultipleRegisterRequest (duplicating the implementation, there might be a better solution), the generated ReadWriteMultipleRegister frame will be correct. After fixing this, I found that the response is rejected, because ReadWriteMultipleRegisters was is not in the functionCode switch.

These commits result in working ReadWriteMultipleRegister support (tested with RTU)

pieterg avatar Apr 20 '23 13:04 pieterg