core icon indicating copy to clipboard operation
core copied to clipboard

[N/A] Refresh system.js switch to named exports

Open pbaize opened this issue 6 years ago • 3 comments

Description of Change

Switches to named exports to improve dev experience. Keeping a single large export to not need changes to other files.

Checklist

  • [ ] PR description included and stakeholders cc'd
  • [ ] npm test passes
  • [ ] automated tests are changed or added
  • [ ] manual tests are changed or added
  • [ ] relevant documentation is changed or added
  • [ ] PR title starts with the JIRA ticket pull request process
  • [ ] PR release notes describe the change in a way relevant to app-developers
  • [ ] Link to new tests added
  • [ ] PR has assigned reviewers

Release Notes

Notes:

pbaize avatar Oct 11 '19 19:10 pbaize

:warning: Failed to build a1336bc

openfin-github-bot[bot] avatar Oct 11 '19 20:10 openfin-github-bot[bot]

7540eab

Git

  • core: develop <= system-refresh-1 (7540eab)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 11 '19 21:10 openfin-github-bot[bot]

got a conflict.

MichaelMCoates avatar Oct 16 '19 14:10 MichaelMCoates