RUN-5674 | BrowserView creates multiply window/close events #2

[tomer-openfin]

Description of Change

extending previous PR for this issue by refactoring the logic and adding .isDestroyed check.

Checklist

• [x] PR description included and stakeholders cc'd
• [x] npm test passes
• [x] PR title starts with the JIRA ticket pull request process
• [x] PR has assigned reviewers

[openfin-github-bot[bot]]

:warning: Failed to build 2bbacb8

[openfin-github-bot[bot]]

221a889

Git

• core: develop <= bv_fix (221a889)
• js-adapter: develop
• javascript-adapter: develop

Asars used for testing

• app.asar
• adapter.asar

Test results

• :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
• :cold_sweat: Windows 10 (64-bit runtime): Failed 2/665
• :scream: Windows 10 (32-bit runtime): Failed 665/665
• :cold_sweat: Windows 7 (32-bit runtime): Failed 1/665

[MichaelMCoates]

Got a conflict

[openfin-github-bot[bot]]

5b935f8

Git

• core: develop <= bv_fix (5b935f8)
• js-adapter: develop
• javascript-adapter: develop

Asars used for testing

• app.asar
• adapter.asar

Test results

• :white_check_mark: Windows 7 (32-bit runtime): Failed 0/665
• :white_check_mark: Windows 10 (64-bit runtime): Failed 0/665
• :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
• :cold_sweat: Windows 10 (32-bit runtime): Failed 1/665

[MichaelMCoates]

This will likely conflict with https://github.com/HadoukenIO/core/pull/976, so may want to wait for that to go in first?

[tomer-openfin]

@MichaelMCoates I don't mind waiting.

[openfin-github-bot[bot]]

de2fa83

Git

• core: develop <= bv_fix (de2fa83)
• js-adapter: develop
• javascript-adapter: develop

Asars used for testing

• app.asar
• adapter.asar

Test results

• :cold_sweat: Windows 10 (32-bit runtime): Failed 2/667
• :scream: Windows 7 (32-bit runtime): Failed 3/667
• :scream: Windows 7 (64-bit runtime): Failed 4/667
• :scream: Windows 10 (64-bit runtime): Failed 51/667