[N/A] Hook up event propagation for all browserview-related events
Description of Change
This PR adds propagated events up to Application and System for BrowserView.
Tests: https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5da8b1ceee166d7a14d451bc
Corresponding js-adapter PR: https://github.com/HadoukenIO/js-adapter/pull/357
@aziz512 trying to add you as reviewer but it won't let me for some reason.
Checklist
- [X] PR description included and stakeholders cc'd
- [X]
npm testpasses - [X] automated tests are changed or added
- [X] relevant documentation is changed or added
- [X] Link to new tests added
- [X] PR has assigned reviewers
Release Notes
Notes:
c7afb49
Git
- core: develop <= dev/coates/bv-event-propagation (c7afb49)
- js-adapter: develop <= dev/coates/bv-event-propagation (eae221f)
- javascript-adapter: develop
Asars used for testing
Test results
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
- :white_check_mark: Windows 7 (32-bit runtime): Failed 0/665
- :cold_sweat: Windows 10 (64-bit runtime): Failed 1/665
- :cold_sweat: Windows 10 (32-bit runtime): Failed 1/665
:warning: Failed to build c55acc4
ab57f1c
Git
- core: develop <= dev/coates/bv-event-propagation (ab57f1c)
- js-adapter: develop <= dev/coates/bv-event-propagation (87dedcf)
- javascript-adapter: develop
Asars used for testing
Test results
- :white_check_mark: Windows 10 (32-bit runtime): Failed 0/665
- :cold_sweat: Windows 10 (64-bit runtime): Failed 1/665
- :white_check_mark: Windows 7 (32-bit runtime): Failed 0/665
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
99ab0e7
Git
- core: develop <= dev/coates/bv-event-propagation (99ab0e7)
- js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
- javascript-adapter: develop
Asars used for testing
Test results
- :cold_sweat: Windows 7 (32-bit runtime): Failed 1/665
- :cold_sweat: Windows 10 (32-bit runtime): Failed 1/665
- :white_check_mark: Windows 10 (64-bit runtime): Failed 0/665
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
27aee21
Git
- core: develop <= dev/coates/bv-event-propagation (27aee21)
- js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
- javascript-adapter: develop
Asars used for testing
Test results
- :scream: Windows 7 (64-bit runtime): Failed 16/665
- :white_check_mark: Windows 10 (32-bit runtime): Failed 0/665
- :scream: Windows 7 (32-bit runtime): Failed 16/665
- :scream: Windows 10 (64-bit runtime): Failed 4/665
The custom window logic is still necessary for view-detached because of the way the routing works in of_events.
fd30fbd
Git
- core: develop <= dev/coates/bv-event-propagation (fd30fbd)
- js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
- javascript-adapter: develop
Asars used for testing
Test results
- :cold_sweat: Windows 7 (32-bit runtime): Failed 2/665
- :cold_sweat: Windows 10 (32-bit runtime): Failed 1/665
- :scream: Windows 10 (64-bit runtime): Failed 21/665
- :cold_sweat: Windows 7 (64-bit runtime): Failed 1/665
bad0f85
Git
- core: develop <= dev/coates/bv-event-propagation (bad0f85)
- js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
- javascript-adapter: develop
Asars used for testing
Test results
- :scream: Windows 7 (32-bit runtime): Failed 3/667
- :cold_sweat: Windows 7 (64-bit runtime): Failed 2/667
- :scream: Windows 10 (64-bit runtime): Failed 12/667
- :cold_sweat: Windows 10 (32-bit runtime): Failed 2/667
After talking with Pierre and Tommy, changed the eventing scheme to the following:
- Windows can listen to
view-attachedandview-detached. - Views can listen to
target-changed. - Window
viewevents don't propagate up to Application and System. - All
viewevents propagate up to Window, Application, and System.
The tests have been updated to reflect these changes.
f877a7f
Git
- core: develop <= dev/coates/bv-event-propagation (f877a7f)
- js-adapter: develop <= dev/coates/bv-event-propagation (2289f59)
- javascript-adapter: develop
Asars used for testing
Test results
- :scream: Windows 7 (32-bit runtime): Failed 4/667
- :scream: Windows 10 (64-bit runtime): Failed 7/667
- :scream: Windows 10 (32-bit runtime): Failed 3/667
- :scream: Windows 7 (64-bit runtime): Failed 3/667