core icon indicating copy to clipboard operation
core copied to clipboard

[N/A] Hook up event propagation for all browserview-related events

Open MichaelMCoates opened this issue 6 years ago • 10 comments

Description of Change

This PR adds propagated events up to Application and System for BrowserView.

Tests: https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5da8b1ceee166d7a14d451bc

Corresponding js-adapter PR: https://github.com/HadoukenIO/js-adapter/pull/357

@aziz512 trying to add you as reviewer but it won't let me for some reason.

Checklist

  • [X] PR description included and stakeholders cc'd
  • [X] npm test passes
  • [X] automated tests are changed or added
  • [X] relevant documentation is changed or added
  • [X] Link to new tests added
  • [X] PR has assigned reviewers

Release Notes

Notes:

MichaelMCoates avatar Oct 02 '19 17:10 MichaelMCoates

c7afb49

Git

  • core: develop <= dev/coates/bv-event-propagation (c7afb49)
  • js-adapter: develop <= dev/coates/bv-event-propagation (eae221f)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 02 '19 17:10 openfin-github-bot[bot]

:warning: Failed to build c55acc4

openfin-github-bot[bot] avatar Oct 10 '19 00:10 openfin-github-bot[bot]

ab57f1c

Git

  • core: develop <= dev/coates/bv-event-propagation (ab57f1c)
  • js-adapter: develop <= dev/coates/bv-event-propagation (87dedcf)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 10 '19 15:10 openfin-github-bot[bot]

99ab0e7

Git

  • core: develop <= dev/coates/bv-event-propagation (99ab0e7)
  • js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 10 '19 18:10 openfin-github-bot[bot]

27aee21

Git

  • core: develop <= dev/coates/bv-event-propagation (27aee21)
  • js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 16 '19 17:10 openfin-github-bot[bot]

The custom window logic is still necessary for view-detached because of the way the routing works in of_events.

MichaelMCoates avatar Oct 16 '19 19:10 MichaelMCoates

fd30fbd

Git

  • core: develop <= dev/coates/bv-event-propagation (fd30fbd)
  • js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 16 '19 20:10 openfin-github-bot[bot]

bad0f85

Git

  • core: develop <= dev/coates/bv-event-propagation (bad0f85)
  • js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 17 '19 16:10 openfin-github-bot[bot]

After talking with Pierre and Tommy, changed the eventing scheme to the following:

  • Windows can listen to view-attached and view-detached.
  • Views can listen to target-changed.
  • Window view events don't propagate up to Application and System.
  • All view events propagate up to Window, Application, and System.

The tests have been updated to reflect these changes.

MichaelMCoates avatar Oct 17 '19 18:10 MichaelMCoates

f877a7f

Git

  • core: develop <= dev/coates/bv-event-propagation (f877a7f)
  • js-adapter: develop <= dev/coates/bv-event-propagation (2289f59)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 17 '19 19:10 openfin-github-bot[bot]