core icon indicating copy to clipboard operation
core copied to clipboard

Run 5493 external window id updates

Open dhamberlin opened this issue 6 years ago • 7 comments

Description of Change

Jira: https://appoji.jira.com/browse/RUN-5493

This PR makes a few changes to the ExternalWindow API:

  • ExternalWindows can be registered by nativeId (nativeId === hwnd in Windows) OR uuid (if the uuid has already been assigned to an external process via e.g. System.launchExternalProcess
  • ExternalWindow.wrap returns a uuid, name, and nativeId to caller, ensuring that render-side ExternalWindows will always have all three, even if user wrapped the window by uuid or nativeId alone.
  • ExternalWindow uuids are locked on registration, released on window close.
  • nativeId is exposed on all ExternalWindow info objects, such as those returned by System.getAllExternalWindows as well as on 'external-window' events.
  • uuid in included on all ExternalWindow info objects and external window events if a) the window has already been wrapped as an ExternalWindow or b) the pid matches a process that is being tracked by ProcessTracker (e.g. those launched by launchExternalProcess)

Related js-adapter PR: https://github.com/HadoukenIO/js-adapter/pull/341

Checklist

  • [x] PR description included and stakeholders cc'd
  • [x] npm test passes
  • [x] automated tests are changed or added ( a couple private ones I will make public post-merge, and more to come)
  • [x] relevant documentation is changed or added (more to come here, working on adding/updating tutorials now)
  • [x] PR title starts with the JIRA ticket pull request process
  • [x] PR release notes describe the change in a way relevant to app-developers (included in js-adapter PR)
  • [x] PR has assigned reviewers

Release Notes

Notes:

dhamberlin avatar Sep 16 '19 18:09 dhamberlin

Test Results for 97047d0

openfin-github-bot[bot] avatar Sep 16 '19 19:09 openfin-github-bot[bot]

Test Results for d62fe42

openfin-github-bot[bot] avatar Sep 17 '19 19:09 openfin-github-bot[bot]

Test Results for 0ea5335

openfin-github-bot[bot] avatar Sep 18 '19 23:09 openfin-github-bot[bot]

0b4518a

Git

  • core: develop <= RUN-5493-external-window-id-updates (0b4518a)
  • js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 08 '19 16:10 openfin-github-bot[bot]

1b8ed89

Git

  • core: develop <= RUN-5493-external-window-id-updates (1b8ed89)
  • js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 11 '19 15:10 openfin-github-bot[bot]

4c2e3ba

Git

  • core: develop <= RUN-5493-external-window-id-updates (4c2e3ba)
  • js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 15 '19 15:10 openfin-github-bot[bot]

884685b

Git

  • core: develop <= RUN-5493-external-window-id-updates (884685b)
  • js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 16 '19 18:10 openfin-github-bot[bot]