core
core copied to clipboard
Run 5493 external window id updates
Description of Change
Jira: https://appoji.jira.com/browse/RUN-5493
This PR makes a few changes to the ExternalWindow API:
- ExternalWindows can be registered by
nativeId(nativeId === hwnd in Windows) OR uuid (if the uuid has already been assigned to an external process via e.g.System.launchExternalProcess -
ExternalWindow.wrapreturns a uuid, name, and nativeId to caller, ensuring that render-sideExternalWindows will always have all three, even if user wrapped the window byuuidornativeIdalone. - ExternalWindow uuids are locked on registration, released on window close.
- nativeId is exposed on all ExternalWindow info objects, such as those returned by
System.getAllExternalWindowsas well as on 'external-window' events. - uuid in included on all ExternalWindow info objects and external window events if a) the window has already been wrapped as an ExternalWindow or b) the pid matches a process that is being tracked by ProcessTracker (e.g. those launched by
launchExternalProcess)
Related js-adapter PR: https://github.com/HadoukenIO/js-adapter/pull/341
Checklist
- [x] PR description included and stakeholders cc'd
- [x]
npm testpasses - [x] automated tests are changed or added ( a couple private ones I will make public post-merge, and more to come)
- [x] relevant documentation is changed or added (more to come here, working on adding/updating tutorials now)
- [x] PR title starts with the JIRA ticket pull request process
- [x] PR release notes describe the change in a way relevant to app-developers (included in js-adapter PR)
- [x] PR has assigned reviewers
Release Notes
Notes:
Test Results for 97047d0
- Asars
- JavaScript
- :scream: Windows 10 (32-bit runtime): Failed 8/664
- :scream: Windows 7 (32-bit runtime): Failed 8/664
- :scream: Windows 7 (64-bit runtime): Failed 8/664
- :scream: Windows 10 (64-bit runtime): Failed 8/664
Test Results for d62fe42
- Asars
- JavaScript
- :cold_sweat: Windows 7 (32-bit runtime): Failed 1/664
- :cold_sweat: Windows 10 (32-bit runtime): Failed 1/664
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/664
- :white_check_mark: Windows 10 (64-bit runtime): Failed 0/664
Test Results for 0ea5335
- Asars
- JavaScript
- :white_check_mark: Windows 10 (64-bit runtime): Failed 0/664
- :white_check_mark: Windows 7 (32-bit runtime): Failed 0/664
- :white_check_mark: Windows 10 (32-bit runtime): Failed 0/664
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/664
0b4518a
Git
- core: develop <= RUN-5493-external-window-id-updates (0b4518a)
- js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
- javascript-adapter: develop
Asars used for testing
Test results
- :scream: Windows 10 (64-bit runtime): Failed 9/665
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
- :cold_sweat: Windows 7 (32-bit runtime): Failed 1/665
- :scream: Windows 10 (32-bit runtime): Failed 7/665
1b8ed89
Git
- core: develop <= RUN-5493-external-window-id-updates (1b8ed89)
- js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
- javascript-adapter: develop
Asars used for testing
Test results
- :white_check_mark: Windows 7 (32-bit runtime): Failed 0/665
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
- :cold_sweat: Windows 10 (64-bit runtime): Failed 1/665
- :white_check_mark: Windows 10 (32-bit runtime): Failed 0/665
4c2e3ba
Git
- core: develop <= RUN-5493-external-window-id-updates (4c2e3ba)
- js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
- javascript-adapter: develop
Asars used for testing
Test results
- :white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
- :cold_sweat: Windows 10 (64-bit runtime): Failed 1/665
- :white_check_mark: Windows 10 (32-bit runtime): Failed 0/665
- :white_check_mark: Windows 7 (32-bit runtime): Failed 0/665
884685b
Git
- core: develop <= RUN-5493-external-window-id-updates (884685b)
- js-adapter: develop <= RUN-5493-external-window-id-updates (5fa4838)
- javascript-adapter: develop
Asars used for testing
Test results
- :scream: Windows 10 (64-bit runtime): Failed 4/665
- :scream: Windows 7 (32-bit runtime): Failed 17/665
- :scream: Windows 7 (64-bit runtime): Failed 17/665
- :cold_sweat: Windows 10 (32-bit runtime): Failed 1/665