core icon indicating copy to clipboard operation
core copied to clipboard

[RUN-5683] Add process.versions.chrome to getRuntimeInfo

Open yongjich opened this issue 6 years ago • 3 comments

Add process.versions.chrome to System.getRuntimeInfo

Link to test: https://testing-dashboard.openfin.co/#/app/tests/5da87d4dee166d7a14d45189/edit

Link to js-adapter PR: https://github.com/HadoukenIO/js-adapter/pull/368

Checklist

Release Notes

Notes:

yongjich avatar Oct 17 '19 17:10 yongjich

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yongjich). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

finos-admin avatar Oct 17 '19 17:10 finos-admin

Code looks good. Can we add a js-adapter pr for the types and maybe test the value in test runner by comparing against userAgent? https://stackoverflow.com/questions/4900436/how-to-detect-the-installed-chrome-version

Okay. Included js-adapter pr and updated test-runner test to compare against userAgent

yongjich avatar Oct 17 '19 17:10 yongjich

954cfe7

Git

  • core: develop <= RUN-5683-getRuntimeInfo (954cfe7)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

openfin-github-bot[bot] avatar Oct 17 '19 18:10 openfin-github-bot[bot]