overlayed icon indicating copy to clipboard operation
overlayed copied to clipboard

Added os aware download card

Open MUK-Dev opened this issue 1 year ago • 9 comments

MUK-Dev avatar Aug 06 '24 05:08 MUK-Dev

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlayed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 3:33pm

vercel[bot] avatar Aug 06 '24 05:08 vercel[bot]

this commit resolves #163

MUK-Dev avatar Aug 06 '24 05:08 MUK-Dev

You need to format the code you've written using pnpm format. Also, the build was unsuccessful.

Pyr33x avatar Aug 06 '24 11:08 Pyr33x

Formatting was the issue. It seems.

MUK-Dev avatar Aug 07 '24 10:08 MUK-Dev

Yes, and I want @Hacksore to wait a bit more time to close the pr, cause I'm currently working on the download ui

Pyr33x avatar Aug 07 '24 10:08 Pyr33x

@MUK-Dev currently the preview env shows Linux on iOS IMG_2553

looks like spacedrvie does a fallback on unsupported devices. IMG_2554

Hacksore avatar Aug 07 '24 11:08 Hacksore

@MUK-Dev currently the preview env shows Linux on iOS

It's same on Android tho

Pyr33x avatar Aug 07 '24 11:08 Pyr33x

Ok, I'll take a look

MUK-Dev avatar Aug 07 '24 12:08 MUK-Dev

Hi, kindly test it again. I only have a windows and android machine so I can't check on others. react-device-detect doesn't detect linux so I had to check for devices manually.

MUK-Dev avatar Aug 07 '24 15:08 MUK-Dev

see https://github.com/overlayeddev/overlayed/issues/163#issuecomment-2325407163

Hacksore avatar Sep 03 '24 00:09 Hacksore