Helix icon indicating copy to clipboard operation
Helix copied to clipboard

Only log "Localhost logged in" upon login (ignore WS reconnection)

Open renatomassaro opened this issue 8 years ago • 3 comments

Currently, Helix naively logs "Localhost logged in" every time the channel is joined, but it may be the case that this join is due to websocket reconnection (internal/transparent to the user). We should detect that a login request was performed (POST /v1/account/login) and only then create the log.

renatomassaro avatar Dec 06 '17 12:12 renatomassaro

im my opinion that may make the game harder which is always good meaning u have to check ur logs more therefore u also may see enemys

Deathslayer222 avatar Jan 11 '18 15:01 Deathslayer222

@Deathslayer222 the main problem is this is a "penalty"[1] totally random from the player point of view (every deployment would result in this log message being generated, as well as player disconnection e.g. switching from mobile data to cable)

[1] - Though to be honest I don't see "Localhost logged in" as a penalty in any way. It's just annoying, since it spams the LogViewer

renatomassaro avatar Jan 11 '18 17:01 renatomassaro

I understand that

Deathslayer222 avatar Jan 11 '18 17:01 Deathslayer222