react-datepicker icon indicating copy to clipboard operation
react-datepicker copied to clipboard

feat: expose outsideClickIgnoreClass

Open meriouma opened this issue 9 months ago • 5 comments

Description

Problem We'd like to configure the name of the click outside ignore class.

Changes Add clickOutsideIgnoreClass to the DatePicker component

To reviewers

Contribution checklist

  • [x] I have followed the contributing guidelines.
  • [x] I have added sufficient test coverage for my changes.
  • [x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

meriouma avatar May 23 '25 15:05 meriouma

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.96%. Comparing base (b9c85a2) to head (3e3d80f). Report is 136 commits behind head on main.

Files with missing lines Patch % Lines
src/index.tsx 66.66% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5645      +/-   ##
==========================================
- Coverage   96.98%   96.96%   -0.03%     
==========================================
  Files          30       30              
  Lines        3355     3365      +10     
  Branches     1416     1421       +5     
==========================================
+ Hits         3254     3263       +9     
- Misses         99      100       +1     
  Partials        2        2              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 23 '25 15:05 codecov[bot]

Can you check the code coverage and see if there's something you can add to get to our coverage levels?

martijnrusschen avatar May 24 '25 11:05 martijnrusschen

@claude review this code

martijnrusschen avatar May 24 '25 11:05 martijnrusschen

Claude encountered an error —— View job


I'll analyze this and get back to you.

claude[bot] avatar May 24 '25 11:05 claude[bot]

Can you check the code coverage and see if there's something you can add to get to our coverage levels?

I tried, I think the issue is with codecov, as I believe the code should be covered with the tests.

meriouma avatar May 26 '25 00:05 meriouma

Can we just ignore the missing line?

meriouma avatar Jun 24 '25 03:06 meriouma