react-datepicker icon indicating copy to clipboard operation
react-datepicker copied to clipboard

Implemented a one-click toggle for the custom time input bar

Open ezParth opened this issue 1 year ago • 2 comments


name: “Fix time input focus issue”

about: The time input in the "Custom time input" example does not focus when clicked on for the first time. It requires two clicks to focus.

title: "Custom time input needs 2 clicks to focus"

labels: ""

assignees: "@martijnrusschen"

Description

Linked issue: #4949

Problem The time input in the “Custom time input” example does not focus when clicked on for the first time. It requires two clicks to focus.

Changes I have fixed the issue by ensuring that the time input is focused on the first click.

Screenshots

Screenshot (22) In the right side when we click the time input bar, I have ensured that the time input is focused on the first click.

To reviewers

Contribution checklist

  • [x] I have followed the contributing guidelines.
  • [x] I have added sufficient test coverage for my changes.
  • [x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

ezParth avatar Jul 05 '24 12:07 ezParth

Please make sure to fix the code formatting with prettier.

martijnrusschen avatar Jul 08 '24 09:07 martijnrusschen

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.34%. Comparing base (17a0a33) to head (c51950c). Report is 276 commits behind head on main.

Files with missing lines Patch % Lines
src/calendar.tsx 50.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4956      +/-   ##
==========================================
- Coverage   96.71%   96.34%   -0.38%     
==========================================
  Files          28       28              
  Lines        3287     3307      +20     
  Branches     1368     1389      +21     
==========================================
+ Hits         3179     3186       +7     
- Misses        104      121      +17     
+ Partials        4        0       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 18 '24 07:07 codecov[bot]