SpeedUpAmerica icon indicating copy to clipboard operation
SpeedUpAmerica copied to clipboard

iframe page for embedding in 3rd party websites

Open mattsayre opened this issue 4 years ago • 27 comments

Is your feature request related to a problem? Please describe. Looking to enable 3rd party branded websites to embed a speedup page, in their website. This will be a survey style form, very similar to how it is done on speedupamerica.com proper, meaning a sequence for taking a speed test of geolocation (use my browsers location/use my addres), then Residential/Mobile/Public, connection tyep (wired/wireless/etc), price, advertised speed. Then return speed results and comparison.

Describe the solution you'd like iframe so that it can be branded by third parties. Only branding inside the frame will be "Powered by SpeedUpAmerica"

Describe alternatives you've considered Javascript embed

Additional context Don't need mapping, this feature is simply for collecting crowdsourced speed test results.

Regional Report Link: https://speedupamerica.com/region_submissions/region_export_csv_report/ (added for future reference - @webaissance )

mattsayre avatar Feb 02 '22 22:02 mattsayre

I am working on this. Didn't see how to assign to myself.

webaissance avatar Feb 05 '22 19:02 webaissance

@webaissance a few copy and other minor edits:

  1. Remove the copy "Test Your Internet Speed Oregon"
  2. Remove the copy "In 5 Steps"
  3. Remove the question about connection type (wired/wifi/cellular) in its entirety.
  4. Change Estimated price per month question to OPTIONAL.
  5. Remove csv Export button from iframe, just need to know the direct link URL.

mattsayre avatar Apr 21 '22 23:04 mattsayre

Okay @mattsayre - I will work on those - give me till tomorrow mid-morning and I'll send these updates through.

webaissance avatar Apr 22 '22 00:04 webaissance

Additional minor edits @webaissance :

  1. Make question 3 (regarding price), optional. This will require the additional change of having question 4 come up to fill out in tandem with question 3.
  2. The "i" hover over in question 3 floats up and is getting cut off (readability). Needs to float down, which should prevent the text from being cutoff.
  3. Remove entire statement on results page, "This test helps...".

mattsayre avatar Apr 25 '22 05:04 mattsayre

Additional minor edit @webaissance

  1. we need to change the language under the "I don't have internet" track, when they enter their address. The copy should be replaced with "I'd like to register my address as a location that doesn't have internet".

mattsayre avatar Apr 27 '22 04:04 mattsayre

Ok. I'll work on sending another PR tomorrow or tonight if possible

On Tue, Apr 26, 2022, 9:50 PM Matt Sayre @.***> wrote:

Additional minor edit @webaissance https://github.com/webaissance

  1. we need to change the language under the "I don't have internet" track, when they enter their address. The copy should be replaced with "I'd like to register my address as a location that doesn't have internet".

— Reply to this email directly, view it on GitHub https://github.com/Hack4Eugene/SpeedUpAmerica/issues/283#issuecomment-1110537833, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAURRHZUG6Z3IODSATMSXDVHDBRTANCNFSM5NNLMY6A . You are receiving this because you were mentioned.Message ID: @.***>

webaissance avatar Apr 27 '22 05:04 webaissance

Matt - I just sent a PR that takes care of all of the remaining tasks for the iFrame issue.

Also - of note - in order to download data you have to inspect the result page and unhide the button. I don't know of a way to trigger the export just via a URL.

The export process can be developed over time more as needed.

Hope tomorrow goes great for the project!

-Dave

On Tue, Apr 26, 2022 at 9:50 PM Matt Sayre @.***> wrote:

Additional minor edit @webaissance https://github.com/webaissance

  1. we need to change the language under the "I don't have internet" track, when they enter their address. The copy should be replaced with "I'd like to register my address as a location that doesn't have internet".

— Reply to this email directly, view it on GitHub https://github.com/Hack4Eugene/SpeedUpAmerica/issues/283#issuecomment-1110537833, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAURRHZUG6Z3IODSATMSXDVHDBRTANCNFSM5NNLMY6A . You are receiving this because you were mentioned.Message ID: @.***>

webaissance avatar Apr 27 '22 11:04 webaissance

@webaissance three additional minor edits:

  1. Add second required checkbox on question 1 (have/have not internet). This will replace the passive agreement and associated language which is currently "By entering your information you agree to the data policy." NEW language next to new checkbox "I agree to the data policy https://www.measurementlab.net/privacy/ and have read the disclaimer <disclaimer site https://test.fasterinternetoregon.org/disclaimer/)>.

  2. Remove entirely the price I would pay question, under the click path for "i don't have internet".

  3. Remove the informational "i" in "What is the estimated price..." question, under the click path of "I have internet access at my home".

mattsayre avatar Apr 28 '22 17:04 mattsayre

@mattsayre I am working on these. I would say anything that's just cosmetic or type change is minor. Anything that changes functionality is small but not minor - because it changes the logic and has the potential to break things and therefore requires more thorough testing. In any case - I will try to get these done asap and send through a PR.

webaissance avatar Apr 29 '22 15:04 webaissance

For 1) - the new Opt-in item - we should probably add this as a database field - for opt-in right? This would involve running the db migrator update again. For now I will not do that - since this appears to be urgent - but can add it later if needed.

webaissance avatar Apr 29 '22 15:04 webaissance

Related to this - wouldn't each region have it's own disclaimer - so the link shouldn't be hardcoded in - but a configuration for each region?

webaissance avatar Apr 29 '22 15:04 webaissance

Thank you. Yes, let’s add that later.

On Apr 29, 2022, at 8:23 AM, Webaissance @.***> wrote:

 For 1) - the new Opt-in item - we should probably add this as a database field - for opt-in right? This would involve running the db migrator update again. For now I will not do that - since this appears to be urgent - but can add it later if needed.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

mattsayre avatar Apr 29 '22 15:04 mattsayre

Good thinking. Let’s also put that on the future roadmap and just hard code it for now.

On Apr 29, 2022, at 8:29 AM, Webaissance @.***> wrote:

 Related to this - wouldn't each region have it's own disclaimer - so the link shouldn't be hardcoded in - but a configuration for each region?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

mattsayre avatar Apr 29 '22 15:04 mattsayre

Okay. And also - the disclaimer link is being hardcoded to the test instance: https://test.fasterinternetoregon.org/disclaimer/ It should go to the live instance - but that's not live yet... In any case - I have added a place in the controller to set different disclaimer links for different regions. PR coming up shortly...

webaissance avatar Apr 29 '22 16:04 webaissance

@webaissance follow-up to our conversation about restoring IP address lookup capability for naming ISP's.

mattsayre avatar May 05 '22 18:05 mattsayre

@webaissance add Spanish language version of iframe. Copy attached iframe language for translation FIO-es-US.docx Of note, Internationalization in Rails: https://guides.rubyonrails.org/i18n.html Also of note, need to link out to the host website and their spanish language translation version of the Disclaimber.

.

mattsayre avatar May 05 '22 18:05 mattsayre

Link to (test) Spanish translation of disclaimer https://test.fasterinternetoregon.org/es/disclaimer/

mattsayre avatar May 06 '22 15:05 mattsayre

@webaissance - BUG - Scenario where user clicks “I do NOT have internet…”, then “Internet is not affordable”, then register my address… it currently initiates a speed test. There should NOT be a speed test initiated in this flow.

mattsayre avatar May 06 '22 15:05 mattsayre

Okay - what should it do instead? What should the button say?

On Fri, May 6, 2022 at 8:51 AM Matt Sayre @.***> wrote:

@webaissance https://github.com/webaissance - BUG - Scenario where user clicks “I do NOT have internet…”, then “Internet is not affordable”, then register my address… it currently initiates a speed test. There should NOT be a speed test initiated in this flow.

— Reply to this email directly, view it on GitHub https://github.com/Hack4Eugene/SpeedUpAmerica/issues/283#issuecomment-1119760946, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAURRHMAOUUZ62EPDNRFZ3VIU5X5ANCNFSM5NNLMY6A . You are receiving this because you were mentioned.Message ID: @.***>

webaissance avatar May 06 '22 15:05 webaissance

When user selects "I do NOT have Internet access..." > Internet is not affordable, they should receive this confirmation message (and not initiate the speed test):

"Thank you for your participation. Get more information on state and federal government discounted Internet access programs: https://www.oregon.gov/puc/pages/oregon-lifeline.aspx”

"Gracias por su participación. Obtenga más información sobre programas del gobierno estatal y federal que ofrecen acceso a Internet con descuento: https://www.oregon.gov/puc/pages/oregon-lifeline.aspx”

When user selects "I do NOT have Internet access..." > Internet is not available..., they receive this confirmation message:

"Thank you for your participation." "Gracias por su participación.”

mattsayre avatar May 07 '22 18:05 mattsayre

@mattsayre - I'm not clear on the process flow for different scenarios - particularly if no internet connection. If no internet - do we still want to collect data - or just do nothing? What about the "register this address as having no internet" option from before?

It would nice to have a flowchart of the scenarios. Here are 2 flowcharts I made. I'm trying to understand if you want scenario A or B - or something else?

SpeedUp-FlowChartA-2022-05-08.pdf

SpeedUp-FlowChartB-2022-05-08.pdf

webaissance avatar May 09 '22 04:05 webaissance

@webaissance yes, we do want to collect data from all form submissions (have and have not internet). Flow chart B is very close, made one edit, see attached flow B version 2

.

mattsayre avatar May 09 '22 05:05 mattsayre

Thanks @mattsayre - now I'm getting clarity. I made an updated flowchart on SmartDraw.com. It allows us to collaborate on Flowcharts via shared links, So you can go in and make edits here as needed -

FlowChartC-2022-05-09.pdf

I think if we collaborate on flow charts like this it will really help provide clarity and accuracy to the project and we can accelerate our progress.

I'm evaluating SmartDraw.com - and also looking at Lucid.co and will evaluate others. If we can leverage some of these amazing tools it will really help!

I will be sending a Pull Request that matches this flowchart as soon as I can.

webaissance avatar May 09 '22 10:05 webaissance

@webaissance additional translation:

Your Results = Sus Resultados

Download Speed = Velocidad de Descarga

Upload Speed = Velocidad de Carga

Ping = Ping

mattsayre avatar May 09 '22 17:05 mattsayre

@webaissance while we work to figure why the 'provider' lookup is not working, let's add IP Address to the csv export, so that it can be derived later in the overall workflow (in the separate analysis tool).

mattsayre avatar May 20 '22 05:05 mattsayre

@webaissance in the CSV export, the significant digits for lat/long appear to be truncating or rounding. Let's work together to ensure that those get read out fully.

mattsayre avatar May 20 '22 06:05 mattsayre

Oh - thanks for catching that. I'll look into fixing it.

On Thu, May 19, 2022 at 11:05 PM Matt Sayre @.***> wrote:

@webaissance https://github.com/webaissance in the CSV export, the significant digits for lat/long appear to be truncating or rounding. Let's work together to ensure that those get read out fully.

— Reply to this email directly, view it on GitHub https://github.com/Hack4Eugene/SpeedUpAmerica/issues/283#issuecomment-1132507641, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAURRDG4EBY3EMFEJMOFPDVK4TSNANCNFSM5NNLMY6A . You are receiving this because you were mentioned.Message ID: @.***>

webaissance avatar May 20 '22 06:05 webaissance